Skip to content

[CI] Test gnuinstall option.#19435

Closed
hageboeck wants to merge 3 commits into
root-project:masterfrom
hageboeck:gnuinstall
Closed

[CI] Test gnuinstall option.#19435
hageboeck wants to merge 3 commits into
root-project:masterfrom
hageboeck:gnuinstall

Conversation

@hageboeck

@hageboeck hageboeck commented Jul 22, 2025

Copy link
Copy Markdown
Member

Test for #19327.

@hageboeck hageboeck self-assigned this Jul 22, 2025
@hageboeck hageboeck changed the title [CI] Add gnuinstall option. [CI] Test gnuinstall option. Jul 22, 2025
@github-actions

github-actions Bot commented Jul 22, 2025

Copy link
Copy Markdown

Test Results

    21 files      21 suites   3d 14h 28m 26s ⏱️
 3 688 tests  3 684 ✅ 0 💤 4 ❌
75 582 runs  75 578 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit b775d16.

♻️ This comment has been updated with latest results.

@ferdymercury

ferdymercury commented Jul 22, 2025

Copy link
Copy Markdown
Collaborator

@hageboeck hageboeck force-pushed the gnuinstall branch 4 times, most recently from 30ae8eb to 2a46a94 Compare August 4, 2025 15:07
@hageboeck hageboeck marked this pull request as ready for review August 5, 2025 08:55
@hageboeck hageboeck requested a review from guitargeek August 5, 2025 08:55

@guitargeek guitargeek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

When gnuinstall=On, ROOT needs to ignore the library directory prefix
while still in the build tree.
To cover the gnuninstall case, switch mac beta and the linux arch-native
builds to gnuinstall.
This is done as an option override on special builds to not affect the
binaries we produce.
@ferdymercury

Copy link
Copy Markdown
Collaborator

This PR is probably superseded by https://github.com/root-project/root/pull/21018/files and can thus be closed?

@guitargeek

Copy link
Copy Markdown
Contributor

Yes, I was just talking about that with Stephan! I'll still have to also enable gnutest=ON on macOS in my PR, and then we can indeed close this PR.

@guitargeek

Copy link
Copy Markdown
Contributor

Superseded by #21018

@guitargeek guitargeek closed this Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clean build Ask CI to do non-incremental build on PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants